This repository was archived by the owner on Aug 21, 2024. It is now read-only.
feat: bulk insert in seeder#7746
Merged
HexaField merged 3 commits intoir-engine:devfrom Mar 21, 2023
aditya-mitra:feat/seeder-speedup
Merged
feat: bulk insert in seeder#7746HexaField merged 3 commits intoir-engine:devfrom aditya-mitra:feat/seeder-speedup
HexaField merged 3 commits intoir-engine:devfrom
aditya-mitra:feat/seeder-speedup
Conversation
HexaField
suggested changes
Mar 14, 2023
HexaField
approved these changes
Mar 21, 2023
Contributor
|
@cla-bot check |
|
Checking that all contributors to this PR are verified. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Using multiple insert, featherjs do will a bulk insert of all the values into MySQL. This will be faster than sequential insertion of templates in loop.
References
Refs #7726
Checklist
QA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.